Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively nested PropTypes API? #320

Closed
drolsen opened this issue Jul 9, 2020 · 1 comment
Closed

Recursively nested PropTypes API? #320

drolsen opened this issue Jul 9, 2020 · 1 comment
Labels

Comments

@drolsen
Copy link

drolsen commented Jul 9, 2020

I'm all for PropTypes, really helps keep me and my teams code all on the same page and agreed upon..

However, is this of anything to be concerned about?

image

I understand it could just be recursively instances of its self and nothing more.. but figured it couldn't hurt to ask what is going on here?

Using:
//unpkg.com/react@16.8.0/umd/react.development.js
//unpkg.com/prop-types@15.7.2/prop-types.js

I almost wanna keep clicking to see if it ends..

@ljharb
Copy link
Collaborator

ljharb commented Jul 9, 2020

It's not concerning; circular references are just fine, look at window.window.window ad infinitum :-)

Indeed, I see that this is intentionally added in #20.

@ljharb ljharb closed this as completed Jul 9, 2020
@ljharb ljharb added the question label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants