Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template literal in factoryWithTypeCheckers breaks es5 compatibility #255

Closed
pfrend opened this issue Feb 11, 2019 · 3 comments
Closed

template literal in factoryWithTypeCheckers breaks es5 compatibility #255

pfrend opened this issue Feb 11, 2019 · 3 comments

Comments

@pfrend
Copy link

pfrend commented Feb 11, 2019

Problem:
Build issues with webpack when using older uglify-js that can't read es6 input

Version: 15.7

Code:
https://github.com/facebook/prop-types/blob/master/factoryWithTypeCheckers.js#L310

Expected:
Only es5 code exported

Example output of error:

ERROR in common.js from UglifyJs
SyntaxError: Unexpected character '`' [./~/prop-types/factoryWithTypeCheckers.js:310,0]

Note:
First issue in here - sorry if I'm missing some issue filing rules. Let me know if you need more info.
Thanks!

@ljharb
Copy link
Collaborator

ljharb commented Feb 11, 2019

Thanks, I’ll have a fix for this published shortly.

@ljharb
Copy link
Collaborator

ljharb commented Feb 11, 2019

v15.7.1 published. Sorry for the inconvenience!

@pfrend
Copy link
Author

pfrend commented Feb 11, 2019

awesome, thanks for the quick response time, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants