Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing issues #162

Closed
char0n opened this issue Feb 21, 2018 · 6 comments
Closed

Licensing issues #162

char0n opened this issue Feb 21, 2018 · 6 comments

Comments

@char0n
Copy link

char0n commented Feb 21, 2018

The latest version of prop-types 15.6.0 on npm contains files prop-types.js and prop-types.min.js. These files represents UMD builds. Unfortunately prop-types.js file contains segments still licensed under BSD + Patents. It can be seen for example here:

/**
 * Copyright (c) 2013-present, Facebook, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the BSD-style license found in the
 * LICENSE file in the root directory of this source tree. An additional grant
 * of patent rights can be found in the PATENTS file in the same directory.
 *
 * 
 */

function makeEmptyFunction(arg) {
  return function () {
    return arg;
  };
}

I think this happened accidentally by creating the UMD build before changing the license headers in the required files. There are totally 3 references to the BSD + Patents and it can be seen here. This may have some legal implications for people using it.

Is it possible to release a patch release fixing this UMD build files ?

Thank you very much

@aweary
Copy link
Contributor

aweary commented Feb 21, 2018

@char0n thanks for the heads up, I verified that building from master does not include the outdated BSD header. cc @sophiebits

@char0n
Copy link
Author

char0n commented Feb 26, 2018

@aweary is it possible to publish a new release with the fixed bundle ? We just cannot use prop-types until it contains the BSD + Patent references.

@aweary
Copy link
Contributor

aweary commented Feb 26, 2018

@char0n I think we could push a patch release. I'll ping the right people to look into this today, sorry about the delay.

@sophiebits
Copy link
Contributor

@char0n You can always build it locally if you want.

@aweary
Copy link
Contributor

aweary commented Feb 26, 2018

@char0n I've published 15.6.1 and verified that prop-types.js no longer contains any BSD license headers. Thanks again for bringing this to our attention!

@char0n
Copy link
Author

char0n commented Feb 27, 2018

Yeah I double checked. Thank for for swift response and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants