Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from production build #16

Closed
aweary opened this issue Apr 10, 2017 · 3 comments
Closed

Remove unused code from production build #16

aweary opened this issue Apr 10, 2017 · 3 comments
Assignees
@aweary

Comments

@aweary
Copy link
Contributor

aweary commented Apr 10, 2017

See facebook/react#9398

Can we remove junk code from PropTypes prod build? It doesn't use bundle-collapser so it ships all those method names (e.g. “fbjs/lib/invariant”). This is fixable if you add “-p bundle-collapser/plugin” to browserify call. Additionally, there seems to be some junk invariant() code which is easy to fix if we just turn this into an inlined error. https://unpkg.com/prop-types@15.5.6/prop-types.min.js
@aweary aweary mentioned this issue Apr 10, 2017
Closed
49 tasks
@gaearon
Copy link
Contributor

gaearon commented Apr 11, 2017

Want to help? @aweary

@aweary aweary self-assigned this Apr 11, 2017
@aweary
Copy link
Contributor Author

aweary commented Apr 11, 2017

@gaearon happy to!

@aweary aweary mentioned this issue Apr 11, 2017
Closed
@aweary
Copy link
Contributor Author

aweary commented Apr 11, 2017

Resolved by #20

@aweary aweary closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aweary aweary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @aweary