Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inspectorProxy with IPV6 localhost address #662

Closed
wants to merge 1 commit into from

Conversation

patrickgalbraith
Copy link
Contributor

Summary

For IPV4 the webSocketDebuggerUrl defaults to ws://localhost:8081 but for IPV6 this defaults to ws://[::]:8081. This causes issues since ws://[::] is not a valid websocket URL, I am guessing it should be ws:[::1] which is the IPV6 equivalent.

Test plan

The webSocketDebuggerUrl should be ws:[::1] rather than ws://[::].

This is related to this issue in Flipper facebook/flipper#1520.

@facebook-github-bot
Copy link
Contributor

Hi @patrickgalbraith!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@motiz88 motiz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @patrickgalbraith, thanks for this!

@facebook-github-bot
Copy link
Contributor

@motiz88 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@motiz88 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@motiz88 merged this pull request in 25be2a8.

facebook-github-bot pushed a commit that referenced this pull request Jul 1, 2021
Summary:
Draft changelog:

* **[Feature]** Add option to use the Hermes parser in the transformer. (6dae163)
* **[Feature]** Update the list of default React Native lazy imports to match the [removal of Picker](facebook/react-native@ad0ccac), which was already deprecated. (7dcb20d)
* **[Feature]** Make the input transform options (e.g. `platform`) available to `experimentalSerializerHook` and `customSerializer`. (#679)
* **[Fix]** Avoid triggering Babel scope caching bugs. (4fea2bd, 1370b7a)
* **[Fix]** Fix Hermes debugger proxy for IPv6. (#662)
* **[Types]** Remove documentation and types for the `postMinifyProcess` option which has been broken since Metro v0.33.0. (5d778de)
* **[Experimental]** Various unstable additions to the transformer config. *These are not covered by semver and can change at any time.* (6482241, 3390274, 5b913fa, #677)

Reviewed By: GijsWeterings

Differential Revision: D29514800

fbshipit-source-id: 89bd4b8a53a701ceaf18867e8e9379fd3401bbbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants