From 279f04f33ef37f1cb7a6e142710d52eab494a01e Mon Sep 17 00:00:00 2001
From: Janic Duplessis <janicduplessis@gmail.com>
Date: Thu, 12 Nov 2020 22:58:02 -0800
Subject: [PATCH] Remove JSON from default asset types (#593)

Summary:
**Summary**

JSON files are currently considered both source and assets so they are duplicated in the js bundle and in the assets copied in the final app. I think this is a better default and if someone relies on json files being also included in the bundle they can add it back in their metro config.

Fixes https://github.com/facebook/metro/issues/487

**Test plan**

Test that json files are no longer present in my app assets and the app still works.

Pull Request resolved: https://github.com/facebook/metro/pull/593

Reviewed By: MichaReiser

Differential Revision: D24904641

Pulled By: cpojer

fbshipit-source-id: 934b31fc022b3c32f57c88d17eaee22a2808728a
---
 .../src/__tests__/__snapshots__/loadConfig-test.js.snap       | 4 ----
 packages/metro-config/src/defaults/defaults.js                | 1 -
 2 files changed, 5 deletions(-)

diff --git a/packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap b/packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap
index 98a02df0f9..7c91d6d818 100644
--- a/packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap
+++ b/packages/metro-config/src/__tests__/__snapshots__/loadConfig-test.js.snap
@@ -31,7 +31,6 @@ Object {
       "mp3",
       "wav",
       "html",
-      "json",
       "pdf",
       "yaml",
       "yml",
@@ -169,7 +168,6 @@ Object {
       "mp3",
       "wav",
       "html",
-      "json",
       "pdf",
       "yaml",
       "yml",
@@ -307,7 +305,6 @@ Object {
       "mp3",
       "wav",
       "html",
-      "json",
       "pdf",
       "yaml",
       "yml",
@@ -445,7 +442,6 @@ Object {
       "mp3",
       "wav",
       "html",
-      "json",
       "pdf",
       "yaml",
       "yml",
diff --git a/packages/metro-config/src/defaults/defaults.js b/packages/metro-config/src/defaults/defaults.js
index 8ff6633217..ef7c7e9eb0 100644
--- a/packages/metro-config/src/defaults/defaults.js
+++ b/packages/metro-config/src/defaults/defaults.js
@@ -38,7 +38,6 @@ exports.assetExts = [
   'wav',
   // Document formats
   'html',
-  'json',
   'pdf',
   'yaml',
   'yml',