Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash dependency from tsx parser #432

Merged
merged 1 commit into from Jun 23, 2021

Conversation

JHilker
Copy link
Contributor

@JHilker JHilker commented May 17, 2021

Resolves #418
Replaces #427

Opening a new PR with some added tests and the suggested fixes since the last PR has set for a few weeks now. Feel free to close this in favor of the PR added by @robyoder, but this bug is painful enough for my use case that I'd love to see it get fixed and released, so figured I'd quickly do some of the legwork for testing it out 馃槃.

The PR:

  • Removes the undeclared dependency on lodash
  • Stops overriding the value of asyncGenerators in the plugins array with jsx
  • Stops mutating the return value of tsOptions

@Daniel15
Copy link
Member

This looks good to me. Thanks @JHilker and @robyoder :)

@Daniel15 Daniel15 merged commit c87ebba into facebook:master Jun 23, 2021
@eps1lon eps1lon mentioned this pull request Jun 26, 2021
1 task
@Daniel15
Copy link
Member

Published this in 0.13.0. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tsx parser imports hoisted lodash version
3 participants