Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VariableDeclarator: don't rename ClassProperty #296

Merged
merged 1 commit into from Jan 16, 2019
Merged

VariableDeclarator: don't rename ClassProperty #296

merged 1 commit into from Jan 16, 2019

Conversation

henryqdineen
Copy link
Contributor

renameTo would mistakenly rename ClassProperty nodes and this fixes that.

I have also noticed that when using bablyon parser we would need support for ignoring ObjectProperty, ObjectMethod and ClassMethod types. Would that make sense to add?

@fkling
Copy link
Contributor

fkling commented Jan 16, 2019 •
edited

Would that make sense to add?

We probably have to, yes. But that can be a separate PR.

@fkling fkling merged commit 76734f7 into facebook:master Jan 16, 2019
@henryqdineen henryqdineen deleted the renameTo-ClassProperty branch January 19, 2019 00:12
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
@henryqdineen henryqdineen mentioned this pull request Jan 29, 2021
Closed
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henryqdineen @fkling @facebook-github-bot