chore: move TransformResult to types package
#9747
Merged
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
move-transform-type
branch
from
5797539
to
9671837
Compare
thymikee
approved these changes
Apr 2, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@jest/test-resultis used in a bunch of places, and its dependency on@jest/transformled to everybody depending on babel, istanbul etc.We might wanna do this in more places. It's essentially why
Configis still in@jest/types- so modules can depend on the type without pulling in the hugejest-config. As longs as we still re-export the type from the specific package (like@jest/transformdoes in this case) so you don't need to care about it, I think this is a cleaner solution.Should move
@jest/test-resultas well, sojest-message-utildoesn't need itTest plan
Green CI