Support async sort in custom testSequencer. #8642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotthovestadt
commented
Jul 4, 2019
| @@ -183,7 +183,7 @@ export default (async function runJest({ | |||
| }), | |||
| ); | |||
|
|
|||
| allTests = sequencer.sort(allTests); | |||
| allTests = await sequencer.sort(allTests); | |||
There was a problem hiding this comment.
This is the entire PR, the rest is test and docs.
scotthovestadt
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8642 +/- ##
======================================
Coverage 63.4% 63.4%
======================================
Files 274 274
Lines 11342 11342
Branches 2770 2771 +1
======================================
Hits 7191 7191
Misses 3534 3534
Partials 617 617
Continue to review full report at Codecov.
|
thymikee
approved these changes
Jul 4, 2019
SimenB
approved these changes
Jul 4, 2019
This was referenced Dec 31, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When overriding
testSequencerwith custom logic, forcing synchronous sorting can be limiting. One use-case is fetching test runtime from an endpoint instead of relying on the local cache; this requires an async roundtrip and is not currently possible.This extremely simple PR adds the optional ability for
sortto return aPromisewithout requiring it to.Test plan
sort.