chore: Delete obsolete emails tag from header comment in test files #8377
Conversation
| @@ -4,7 +4,6 @@ | |||
| * This source code is licensed under the MIT license found in the | |||
| * LICENSE file in the root directory of this source tree. | |||
| * | |||
There was a problem hiding this comment.
The blank line under license can probably go too, yeah?
There was a problem hiding this comment.
A few .ts files that I looked at for example have one:
* LICENSE file in the root directory of this source tree.
*
*/
There was a problem hiding this comment.
Yeah it's totally inconsistent across the code base. I've learned to ignore it ^^
There was a problem hiding this comment.
lazy removal of @flow pragmas is my guess
There was a problem hiding this comment.
Yes, that is a tactful way to say that I was consistently lazy, bro ❤️
Codecov Report
@@ Coverage Diff @@
## master #8377 +/- ##
=======================================
Coverage 62.29% 62.29%
=======================================
Files 266 266
Lines 10729 10729
Branches 2609 2609
=======================================
Hits 6684 6684
Misses 3460 3460
Partials 585 585Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Delete 14 occurrences of
* @emails oncall+jsinfraline in header comment:e2e/babel-plugin-jest-hoist/__tests__/integration.test.jse2e/babel-plugin-jest-hoist/__tests__/integrationAutomockOff.test.jse2e/babel-plugin-jest-hoist/__tests__/typescript.test.tse2e/failures/__tests__/assertionCount.test.jse2e/failures/__tests__/assertionError.test.jse2e/failures/__tests__/asyncFailures.test.jse2e/failures/__tests__/errorAfterTestComplete.test.jse2e/failures/__tests__/snapshot.test.jse2e/failures/__tests__/snapshotWithHint.test.jse2e/failures/__tests__/testMacro.test.jse2e/snapshot-mock-fs/__tests__/snapshot.test.jse2e/snapshot/__tests__/secondSnapshot.test.jse2e/snapshot/__tests__/snapshot.test.jspackages/jest-runtime/src/__tests__/Runtime-sourceMaps.test.jsTest plan
Now I remember why I didn’t delete them when I first noticed:
e2e/__tests__/__snapshots__/failures.test.ts.snaptoContainexpected strings ine2e/__tests__/failures.test.tsCI will tell us how effective my local testing of Node versions was (made me feel like Simen lite :)