Inline snapshots: do not indent empty lines.

[scotthovestadt]

Summary

Problem as reported by @zertosh :

One issue I found though is that if your output has new lines somewhere, they become just indented whitespace - as expected. But most editors have automatic trailing whitespace removal, so you end up changing the test just by saving.

The obvious concern here is that, if for whatever reason a snapshot is relying on whitespace on a certain line, we don't want to impact that... even if some editors are going to automatically remove it.

To resolve, I've just stopped indenting empty lines IF they are completely empty.

Test plan

• Added unit test to verify behavior. The test previously fails, it now passes.
• Added e2e tests for behavior.

[thymikee]

👍

[zertosh]

Any chance this can go out in a patch release?

[SimenB]

Seems like a bug in those editors - removing trailing whitespace in a template literal changes the string. In this case (snapshots), it doesn't really matter or course :)

[scotthovestadt]

@zertosh Will push out soon.

@SimenB Yeah, I agree it's a little strange to have editors changing things inside of template literals, but I'm able to reproduce it

[alfaproject]

Also, git does that as well if you configure it to do so, which I usually do

[zertosh]

Can I bug someone to please do a release with this fix? :)

[scotthovestadt]

@zertosh Yeah, plan to do shortly... but FYI at Facebook we're now on master branch so you should have it there :)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.