Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): correct url in error message #13483

Merged
merged 3 commits into from Oct 21, 2022
Merged

Conversation

moonrailgun
Copy link
Contributor

Summary

in latest document. not have this path.

Test plan

image

try to trigger this error, (use old version code style)

example:

module.exports = {
  process(src, filename, config, options) {
       return 'module.exports = ' + JSON.stringify(path.basename(filename)) + ';'
  },
};

in latest document. not have this path.
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@moonrailgun
Copy link
Contributor Author

Oh thank you for your snap update, i am annoying about how to build jest develop context.

@SimenB
Copy link
Member

SimenB commented Oct 21, 2022

@moonrailgun doesn't the instructions in CONTRIBUTING.md work? https://github.com/facebook/jest/blob/main/CONTRIBUTING.md#workflow-and-pull-requests

@SimenB SimenB changed the title docs: fix incorrect url fix(transformer): correct url in error message Oct 21, 2022
@SimenB SimenB merged commit a1a2c20 into jestjs:main Oct 21, 2022
@moonrailgun
Copy link
Contributor Author

@SimenB

I am learning,

To be honest, after i simple git clone -> yarn -> yarn test throw error, i am going to seek for jest document.

And then i found you help me to do this. Thanks bro.

@SimenB
Copy link
Member

SimenB commented Oct 21, 2022

git clone, yarn, yarn build, yarn test should work fine 🙂 If you have ideas on how to make our contributing docs better, I'd love to discuss. Making it easier for contributors is one of our top priorities 👍

@SimenB
Copy link
Member

SimenB commented Oct 24, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants