Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify wording in GettingStarted.md #13447

Merged
merged 5 commits into from Oct 27, 2022
Merged

docs: clarify wording in GettingStarted.md #13447

merged 5 commits into from Oct 27, 2022

Conversation

waikoo
Copy link
Contributor

@waikoo waikoo commented Oct 16, 2022

Fix 1 word to avoid confusion

Summary

Changed "Jest does not fully supported by vite..." to "Jest is not fully supported by vite..." because the original version's first 4 words lead the reader to believe that it's Jest that's not supporting Vite... until you make out later from the context that the reason for Jest not being supported is due to Vite's plugin system.

Test plan

No code, just grammar.

Fix 1 word to avoid confusion
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you update all versions of this doc? 🙂

@waikoo
Copy link
Contributor Author

waikoo commented Oct 16, 2022

Thanks! Can you update all versions of this doc? slightly_smiling_face
@SimenB
Sorry, what do you mean by "all versions"? This is my first pull request.

@SimenB
Copy link
Member

SimenB commented Oct 16, 2022

image

@waikoo
Copy link
Contributor Author

waikoo commented Oct 17, 2022

@SimenB Updated the ones that had a section about Vite in pull request #13453.

@SimenB
Copy link
Member

SimenB commented Oct 17, 2022

Could you combine the PRs? 😅 Just cleaner in git history. We squash on merge, so feel free to stack the commits

@waikoo
Copy link
Contributor Author

waikoo commented Oct 20, 2022

Sorry, I don't know how to do that. Would it be better if I deleted the existing requests and do it in one pull request?

@SimenB
Copy link
Member

SimenB commented Oct 20, 2022

from this branch (patch-1) you can do git merge main then push. I can do that in this PR for you if it doesn't work?

No need for a new PR 👍

@waikoo
Copy link
Contributor Author

waikoo commented Oct 25, 2022

2022-10-26_01-24
I tried to do that but it doesn't seem like it did anything. Could you do it please? I'm sorry.

@facebook-github-bot
Copy link
Contributor

Hi @waikoo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@SimenB
Copy link
Member

SimenB commented Oct 27, 2022

@waikoo OK, I've merged them now 🙂

It seems the CLA bot didn't run until now. Could you sign in?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB SimenB changed the title Update typo in GettingStarted.md docs: clarify wording in GettingStarted.md Oct 27, 2022
@SimenB SimenB merged commit e3657a3 into jestjs:main Oct 27, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants