Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: webpack admonitions #13311

Merged
merged 4 commits into from Sep 23, 2022
Merged

docs: webpack admonitions #13311

merged 4 commits into from Sep 23, 2022

Conversation

paulreece
Copy link
Contributor

Summary

Test plan

@paulreece paulreece mentioned this pull request Sep 22, 2022
Closed
mrazauskas
mrazauskas reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@mrazauskas mrazauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Would be nice to update versioned docs as well.

docs/Webpack.md Outdated Show resolved Hide resolved
docs/Webpack.md Outdated Show resolved Hide resolved
docs/Webpack.md Outdated Show resolved Hide resolved
paulreece and others added 3 commits September 22, 2022 21:03
@paulreece @mrazauskas
Update docs/Webpack.md
22f1a7b 
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
@paulreece @mrazauskas
Update docs/Webpack.md
8f2605d 
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
@paulreece @mrazauskas
Update docs/Webpack.md
b0f677d 
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
SimenB
SimenB approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Webpack admonitions. #12495 docs: webpack admonitions Sep 23, 2022
@SimenB SimenB merged commit c3a000e into jestjs:main Sep 23, 2022
@matejcik matejcik mentioned this pull request Oct 6, 2022
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrazauskas mrazauskas mrazauskas left review comments

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulreece @SimenB @mrazauskas @facebook-github-bot