fix(jest-mock): align behaviour and return type of generateFromMetadata method
#13207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
force-pushed
the
fix-generateFromMetadata-return-type
branch
from
7f18c36
to
c2cc661
Compare
mrazauskas
commented
Sep 2, 2022
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| /* eslint-disable local/ban-types-eventually, local/prefer-rest-params-eventually */ | |||
|
|
|||
| export type MockFunctionMetadataType = | |||
| export type MockMetadataType = | |||
There was a problem hiding this comment.
Having Function in this and MockFunctionMetadata type is misleading. Sounds like they are related with mock functions, but in fact these are definitions for mocked modules / objects. Might be helpful to change the names for future readers.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #13202
Summary
Current return type of
generateFromMetadatamethod ofModuleMockerisMock<T>. That is the type ofjest.fn(), but not of a mocked module. This PR implementsMocked<T>as the return type.Few more internal types got cleaned up. For instance, it appeared that I was misusing
UnknownFunctiontype previously.Test plan
Type tests added.