Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): also check for package.json #12983

Merged
merged 1 commit into from Jul 10, 2022
Merged

Conversation

milahu
Copy link
Contributor

@milahu milahu commented Jul 1, 2022

when doing yarn build and git checkout for old versions
getPackages returns false positives, where the package folder exists, but package.json is missing

@milahu milahu marked this pull request as ready for review July 1, 2022 20:10
@vitkarpov
Copy link
Contributor

Out of curiosity, what's that folder with no package.json in it? I wonder why there's a "package" with no package.json

@milahu
Copy link
Contributor Author

milahu commented Jul 3, 2022

to reproduce

git clone https://github.com/facebook/jest
cd jest
yarn install
yarn build
git checkout 26.6.2
yarn install
yarn build # throws "blabla no package.json"

the folders without package.json contain build/ folders created by the first yarn build

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants