Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect-utils): Fix equalityof ImmutableJS OrderedSets #12977

Merged
merged 2 commits into from Jun 30, 2022

Conversation

pbomb
Copy link
Contributor

@pbomb pbomb commented Jun 29, 2022

Summary

Fixes #12976

Test plan

I added an iterableEquality test for two OrderedSets that have the same contents, but were not considered equal before this change. This PR follows the changes made in #12899 for a similar issue.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 0c37619 into jestjs:main Jun 30, 2022
@SimenB
Copy link
Member

SimenB commented Jul 13, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Immutable.OrderedSet equality comparison failure
3 participants