feat(jest-leak-detector): use FinalizationRegistry when it exists to get rid of external dependency #12973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enrilzhou
force-pushed
the
enril/leak-detector-use-native
branch
from
bb25800
to
cc34f42
Compare
SimenB
approved these changes
Jun 28, 2022
SimenB
reviewed
Jun 28, 2022
SimenB
reviewed
Jun 28, 2022
enrilzhou
force-pushed
the
enril/leak-detector-use-native
branch
3 times, most recently
from
a12280c
to
d6853ec
Compare
…get rid of external dependency
enrilzhou
force-pushed
the
enril/leak-detector-use-native
branch
from
d6853ec
to
61f3366
Compare
This was referenced Aug 3, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the past, the leak detector required external dependency 'weak-napi', a C module, to be installed and work. Now since node has supported the FinalizationRegistry from ECMA, we can use this native object when available to reduce external dependency.
Test plan
Could keep using the existing unit test.