Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-worker): make JestWorkerFarm helper type to include methods that take more than one argument #12839

Merged
merged 2 commits into from May 13, 2022

Conversation

mrazauskas
Copy link
Contributor

Summary

Apparently JestWorkerFarm helper type does not include methods of worker module that take more than one argument. Spread operator was missed in FunctionLike type. Fixed that.

Test plan

Type tests are added.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB
Copy link
Member

SimenB commented May 13, 2022

@mrazauskas
Copy link
Contributor Author

I was checking this already. Must be fixed in jest-runner-tsd. Currently for passing tests it returns failureMessages: [undefined] instead of empty array. undefined is causing this printout. I could add a check in GitHub Actions reporter, but perhaps better to fix the runner. Or both?

@SimenB
Copy link
Member

SimenB commented May 13, 2022

Both, I think? Reporter should probably warn on empty, not ignore (i.e. filter)

@SimenB SimenB merged commit 741d34b into jestjs:main May 13, 2022
@mrazauskas mrazauskas deleted the fix-JestWorkerFarm-type branch May 13, 2022 08:39
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants