Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document differences in coverage ignore comments between providers #12836

Merged
merged 4 commits into from May 13, 2022
Merged

Document differences in coverage ignore comments between providers #12836

merged 4 commits into from May 13, 2022

Conversation

spenserblack
Copy link
Contributor

Summary

It wasn't immediately clear how to ignore lines from the coverage report, and where to find the documentation on ignore comments.

This adds a note to the coverageProvider configuration option providing the basic ignore comments to ignore a line, and also permalinks to documentation for more complex ignore comment usage.

Addresses #12835

Test plan

Only documentation was changed, so likely N/A 馃

Documents how to ignore lines for coverage statistics, and the
differences between providers.
@facebook-github-bot
Copy link
Contributor

Hi @spenserblack!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@spenserblack
Copy link
Contributor Author

I found my changes in f14e29a to be overly wordy once I previewed, but I left the commit in there in case that level of detail is preferred after all.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

docs/Configuration.md Outdated Show resolved Hide resolved
@mrazauskas
Copy link
Contributor

Sounds good. Reads well next to coverageProvider, but it feels like this note would be more useful next to collectCoverage. Only that it would be strange to talk about babel / v8 there.

Just thinking out loud, feel free to rework. What if collectCoverage documentation would be extended like this:

  ### `collectCoverage` \[boolean]

  Default: `false`

  Indicates whether the coverage information should be collected while executing the test. Because this retrofits all executed files with coverage collection statements, it may significantly slow down your tests.

+ Jest ships with two coverage providers: `babel` (default) and `v8`. See [`coverageProvider`](#coverageProvider) option for more details.
+
+ :::note
+ 
+ The `babel` and `v8` providers use `/* istanbul ignore next */` and `/* c8 ignore next */` comments to exclude lines from coverage reports, respectively. For more information, you can view the [`istanbuljs` documentation](https://github.com/istanbuljs/nyc#parsing-hints-ignoring-lines) and the [`c8` documentation](https://github.com/bcoe/c8#ignoring-uncovered-lines-functions-and-blocks).
+ 
+ :::

@spenserblack
Copy link
Contributor Author

spenserblack commented May 12, 2022

What if collectCoverage documentation would be extended like this:

Yeah, it does look better there. Definitely easier to find, since that's probably where users will first look when setting up coverage. I'll move the comment and apply your suggestions.

spenserblack and others added 2 commits May 12, 2022 08:37
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
Moves from the note from under the `coverageProvider` section to under
the `collectCoverage` section.

Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
@mrazauskas
Copy link
Contributor

Thanks! Looks good for my eye.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks!

@SimenB SimenB linked an issue May 13, 2022 that may be closed by this pull request
@SimenB SimenB merged commit 017a438 into jestjs:main May 13, 2022
@spenserblack spenserblack deleted the docs/coverage-comments branch May 13, 2022 11:48
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Document v8 code coverage options
4 participants