Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): adjust typings of *CalledWith matchers to allow a case there a mock was called with no arguments #12807

Merged
merged 2 commits into from May 4, 2022

Conversation

mrazauskas
Copy link
Contributor

Fixes #12804

Summary

As it was reported, typings of lastCalledWith, nthCalledWith, toBeCalledWith matchers should allow to test a case there a mock was called with no arguments:

test('mock called with no arguments', () => {
  mockFn();

  expect(mockFn).lastCalledWith();
  expect(mockFn).nthCalledWith(2);
  expect(mockFn).toBeCalledWith();
});

Test plan

Type tests are adjusted accordingly.

@mrazauskas mrazauskas changed the title fix(expect): improve types of *CalledWith matchers fix(expect): adjust typings of *CalledWith matchers to allow a case there a mock was called with no arguments May 4, 2022
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@SimenB SimenB merged commit a5bb884 into jestjs:main May 4, 2022
@mrazauskas mrazauskas deleted the fix-CalledWith-types branch May 4, 2022 14:31
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in V28: expect@28.X types toHaveBeenCalledWith forcing at least one argument.
3 participants