fix: Allow updating inline snapshots when test includes JSX #12760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Apr 27, 2022
eps1lon
force-pushed
the
fix/update-inline-snapshot-jsx
branch
from
4fd47bd
to
586ac6e
Compare
eps1lon
force-pushed
the
fix/update-inline-snapshot-jsx
branch
from
586ac6e
to
23ce2ca
Compare
|
I take it there's no workaround possible in the meantime? |
SimenB
force-pushed
the
fix/update-inline-snapshot-jsx
branch
from
37ec078
to
e8f607f
Compare
SimenB
reviewed
Aug 19, 2022
Comment on lines
+109
to
+122
| if (error.message.includes('@babel/plugin-syntax-jsx')) { | ||
| try { | ||
| const jsxSyntaxPlugin: PluginItem = [ | ||
| require.resolve('@babel/plugin-syntax-jsx'), | ||
| {}, | ||
| // unique name to make sure Babel does not complain about a possible duplicate plugin. | ||
| 'JSX syntax plugin added by Jest snapshot', | ||
| ]; | ||
| ast = parseSync(sourceFile, { | ||
| filename: sourceFilePath, | ||
| plugins: [...plugins, jsxSyntaxPlugin], | ||
| presets, | ||
| root: rootDir, | ||
| }); |
SimenB
reviewed
Aug 19, 2022
Comment on lines
+113
to
+115
| {}, | ||
| // unique name to make sure Babel does not complain about a possible duplicate plugin. | ||
| 'JSX syntax plugin added by Jest snapshot', |
There was a problem hiding this comment.
probably don't need this as the error is due to this plugin missing
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11561
Note that the fix by @SimenB does not fix the added test because the test passes the babel config directly to babel-jest instead of being declared in a babel.config.js.
It seems to me that
saveSnapshotsForFileshould ultimately ensure it transforms the source with the same transformer that was passed to Jest. It looks like it's currently assuming Babel with pre-defined plugins.Though we can't actually accept any transformer since their AST format may differ and we currently use the AST to find
toMatchInlineSnapshotcalls.I guess for now we focus on fixing this when using Babel and keep the old behavior when Babel isn't used?
Test plan
yarn jest toMatchInlineSnapshotWithJSX