Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add needed capitalization #12246

Merged
merged 6 commits into from Feb 5, 2022
Merged

chore(docs): add needed capitalization #12246

merged 6 commits into from Feb 5, 2022

Conversation

Cambuchi
Copy link
Contributor

Beginning of new sentence needs capitalization.

Beginning of new sentence needs capitalization.
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #12246 (c5bd256) into main (5d483ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12246   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         328      328           
  Lines       17246    17246           
  Branches     5071     5071           
=======================================
  Hits        11643    11643           
  Misses       5570     5570           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d483ce...c5bd256. Read the comment docs.

Copy link
Contributor

@Biki-das Biki-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @Cambuchi thanks for the PR, but why did you made two similar PR, and yes you are right the starting letter should be uppercase, but webpack is written in this way, even in their official site, w link- https://webpack.js.org/ is smallcase so think this change is not important.

thank you.

@Cambuchi
Copy link
Contributor Author

Cambuchi commented Jan 16, 2022

@Biki-das Webpack definitely capitalizes itself when it's the first word even on it's own documentation. See below from their own docs:

image

I found the error on two different files and did quick edits through GitHub not in an editor. Hence the two PRs.

@Biki-das
Copy link
Contributor

@Biki-das Webpack definitely capitalizes itself when it's the first word even on it's own documentation. See below from their own docs:

image

I found the error on two different files and did quick edits through GitHub not in an editor. Hence the two PRs.

@Cambuchi would you close the previous one, and just push it from the new one.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! can you update versioned docs as well?

image

in the same PR is preferable 🙂

@Cambuchi
Copy link
Contributor Author

Sure thing, versioned files have edits committed.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants