Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: HTTP => HTTPS #12063

Merged
merged 1 commit into from Nov 26, 2021
Merged

README.md: HTTP => HTTPS #12063

merged 1 commit into from Nov 26, 2021

Conversation

Schweinepriester
Copy link
Contributor

Summary

Checked the link, skipping the redirect HTTP => HTTPS this way 0:-)

Test plan

Not applicable.

@facebook-github-bot
Copy link
Contributor

Hi @Schweinepriester!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Schweinepriester
Copy link
Contributor Author

Schweinepriester commented Nov 12, 2021

I tried to sign the CLA, seems to take a while to update…?

@codecov-commenter
Copy link

Codecov Report

Merging #12063 (9b4b4f1) into main (42b020f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12063   +/-   ##
=======================================
  Coverage   68.88%   68.88%           
=======================================
  Files         324      324           
  Lines       16669    16669           
  Branches     4814     4814           
=======================================
  Hits        11483    11483           
  Misses       5153     5153           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b020f...9b4b4f1. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@crypt096 crypt096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants