Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PrettyFormatOptions type #11801

Merged
merged 2 commits into from Sep 3, 2021
Merged

Export PrettyFormatOptions type #11801

merged 2 commits into from Sep 3, 2021

Conversation

harelmo
Copy link
Contributor

@harelmo harelmo commented Aug 31, 2021

Summary

Without PrettyFormatOptions exported, Config from @jest/types cannot be used in another TS project since tsc gives the following error:

index.ts:16:7 - error TS4023: Exported variable 'X' has or is using name 'PrettyFormatOptions' from external module "/Users/.../node_modules/@jest/types/build/Config" but cannot be named.

Test plan

None

@facebook-github-bot
Copy link
Contributor

Hi @harelmo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #11801 (28e310f) into master (98f10e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11801   +/-   ##
=======================================
  Coverage   69.04%   69.04%           
=======================================
  Files         312      312           
  Lines       16366    16366           
  Branches     4746     4746           
=======================================
  Hits        11300    11300           
  Misses       5039     5039           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f10e6...28e310f. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB SimenB requested a review from orta August 31, 2021 13:15
Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me 👍🏻

@harelmo
Copy link
Contributor Author

harelmo commented Aug 31, 2021

@orta Thanks for the quick approval!
I've got one check failing, though I'm not sure it's related to my change, and I'm rebased on master. How can it be re-run?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB SimenB merged commit 3c511fd into jestjs:master Sep 3, 2021
@harelmo harelmo deleted the export-PrettyFormatOptions-interface branch September 4, 2021 07:57
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants