feat(config): allow passing option to force node crawl #11264
Conversation
|
Thanks for making this change! Just want to add a note that I was benchmarking jest locally (M1 MacBook Air with macOS 11.2.3), and noticed that In our relatively small monorepo, this results in a find execution that takes several seconds and produces a huge output (43512 lines / 6MB of text). |
|
Ah, that's a very good point. Exclusions in |
|
Yep. I also understand that it may be difficult to translate to a |
On my M1 MacBook Air I can now run **all** the tests in about 16 seconds. Running a single small test file is down from 15sec to <2sec. There were a few components to this: - Jest would take several seconds to load `jest.config.ts` files (jestjs/jest#11337). Fixed by replacing them with `jest.config.json` files. - Jest tries to use the native `find` if available over node fs, but it doesn't pass any exclude options to find, which means that it has to wait a few seconds for `find`, then filter a huge list of all .js files in app/node_modules. Upgrading jest lets us pass a config option to force it to use node fs instead (jestjs/jest#11264 (comment)). - `jsdom` is no longer the default environment in jest, and there is some overhead to jsdom. We are embracing this change by only enabling jsdom in certain test files that need it. Unfortunately Jest only recognizes the `/** @jest-environment jsdom */` comment if it is at the very beginning of the file, so I had to replace our eslint-plugin-header rule with a custom rule to enforce the presence of license headers. - Converted the custom `?raw` transformer to .js instead of .ts, since we are not using ts-node anymore. - Actually executing the test files with ts-jest was slow, because it has to run the TS compiler. Instead we can use babel-jest which doesn't do type checking. kulshekhar/ts-jest#961 (comment) (This also requires enabling `isolatedModules` in tsconfig.) For better or worse, our regular webpack build already typechecks our test files.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Due to #9351 (comment), I want to allow people to configure it.
We should consider defaulting to the Node crawl, but that's separate. With this, at least people can choose
Test plan
Verified via debug statements the option makes it all the way through from jest config to haste-map