fix(hoist-plugin): hoist pure constants to support experimental JSX transform in mocks

[SimenB]

Summary

Fixes #10690 (eventually, hopefully, possibly)

Test plan

Note that I don't want this test to actually land. It's a very brute force way of illustrating the bug, but a bad test to add to ensure we don't have regressions in the future pushed a better test now

[SimenB]

one thing we could do is to wrap it in a function and replace usage - similar to what we do with _getJestObj now. then we wouldn't have to move it

[SimenB]

@nicolo-ribaudo @jeysal I pushed a commit that replaces the reference with its constant value. It works for this case, but I'd love to add some more tests to ensure it doesn't break other cases. Ideas? And if this approach is dumb, I have zero attachment to it and would love to throw it out if you've got any great ideas 😀

[SimenB]

Through more trial & error than I'd like to admit I think I've gotten a function replacement working. I have no idea if that's a better approach or not. I've rebased and squashed some WIP commits so hopefully it'll be relatively simple for you to review the approaches. Commits are

1. add a failing test
2. add code to detect if it's a "safe" access which makes the test not throw, but don't actually do anything, so it's only safe if lazy accessed (which is the case for this test, but not necessarily true)
3. replace the reference with its constant value
4. inject a function which returns the constant value, and call that function instead

Again, feedback appreciated on which of 3 or 4 (if either) is the best solution 🙂

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.