Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct check for compatible find binary #10346

Merged
merged 4 commits into from Jul 31, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 31, 2020

Summary

Fixes #10339

Test plan

Verified on Windows VM. Not sure how to write a test for this… I'm quite confused by why our windows tests pass without this - I doubt watchman is installed. Maybe they have some other find?

@SimenB
Copy link
Member Author

SimenB commented Jul 31, 2020

FYI @richardlau 🙂

@richardlau
Copy link
Contributor

richardlau commented Jul 31, 2020

Verified on Windows VM. Not sure how to write a test for this… I'm quite confused by why our windows tests pass without this - I doubt watchman is installed. Maybe they have some other find?

The test mocks child_process so doesn't actually spawn.
https://github.com/facebook/jest/blob/41436be27aef1b5968d5360062e5599d206f16d8/packages/jest-haste-map/src/crawlers/__tests__/node.test.js#L11-L35

@SimenB
Copy link
Member Author

SimenB commented Jul 31, 2020

Verified on Windows VM. Not sure how to write a test for this… I'm quite confused by why our windows tests pass without this - I doubt watchman is installed. Maybe they have some other find?

The test mocks child_process so doesn't actually spawn.

Right, but we test Jest using Jest itself, and spawn an instance of Jest in every e2e test. So I'd have thought CI would fail when trying to run any tests, not these specific unit tests.

@SimenB SimenB merged commit 2ab3fb2 into jestjs:master Jul 31, 2020
@SimenB SimenB deleted the find-windows branch July 31, 2020 10:49
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest 26.2.1 regression: “No tests found” on Windows
3 participants