Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): support v12 node typings #10336

Merged
merged 5 commits into from Jul 30, 2020
Merged

fix(worker): support v12 node typings #10336

merged 5 commits into from Jul 30, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 30, 2020

Summary

People using "older" @types/node will get type errors with the import

Test plan

Installed a version of @types/node that matches our engine requirement. Without the changes here, there's a type error now

SimenB
SimenB commented Jul 30, 2020
View reviewed changes
package.json
@@ -17,7 +17,7 @@
"@types/babel__template": "^7.0.0",
"@types/dedent": "0.7.0",
"@types/jest": "24.0.2",
"@types/node": "*",
"@types/node": "~10.14.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/facebook/jest/blob/3bdb8e33fc0c94a35c1209df299d5e6ef17ee68d/package.json#L129-L131

@SimenB SimenB merged commit 2db6aa1 into jestjs:master Jul 30, 2020
@SimenB SimenB deleted the worker-types branch July 30, 2020 11:33
@G-Rath
Copy link
Contributor

G-Rath commented Jul 31, 2020

Shouldn't the dependencies on @types/node be just >= 10.14.2, because Jest supports higher than Node 10?

I'm not even sure if typescript respects nested node _modules when searching for @types tbh 🤔

@SimenB
Copy link
Member Author

SimenB commented Jul 31, 2020 •
edited

Shouldn't the dependencies on @types/node be just >= 10.14.2, because Jest supports higher than Node 10?

I want to install the lowest one without manually messing in the lockfile.

I'm not even sure if typescript respects nested node _modules when searching for @types tbh 🤔

It does, otherwise this pr would have failed CI due to the 14 one I added

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimenB @G-Rath @facebook-github-bot