Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create v26, fold v25.x into a single version #9956

Merged
merged 2 commits into from May 4, 2020

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented May 3, 2020

Summary

Updating documentation for the upcoming v26. Folded multiple 25 minor versions into a single 25.x.

Test plan

Local, clicked through some core pages and seems to work as expected.

image

@thymikee thymikee requested a review from SimenB May 3, 2020 09:51
@thymikee thymikee added this to the Jest 26 milestone May 3, 2020
@codecov-io
Copy link

codecov-io commented May 3, 2020

Codecov Report

Merging #9956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9956   +/-   ##
=======================================
  Coverage   64.06%   64.06%           
=======================================
  Files         293      293           
  Lines       12457    12457           
  Branches     3067     3069    +2     
=======================================
  Hits         7981     7981           
  Misses       3833     3833           
  Partials      643      643           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a16415...99a0932. Read the comment docs.

@thymikee thymikee changed the title docs: create v26, fold v25.x into single version docs: create v26, fold v25.x into a single version May 3, 2020
@SimenB
Copy link
Member

SimenB commented May 3, 2020

Reviewing on mobile crashes chrome, but I assume it's good 😃 need to make sure any doc updates get in here as well

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB
Copy link
Member

SimenB commented May 4, 2020

Does this come with the updated docs for fake timers? Only doc change I know of after this was opened

@thymikee
Copy link
Collaborator Author

thymikee commented May 4, 2020

Yup, I rebased it recently and it's there

@SimenB SimenB merged commit 3669a86 into jestjs:master May 4, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants