jest-snapshot: Fix regression in diff for jest-snapshot-serializer-raw #9419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add a test as well? No blocker of course 🙂 |
|
Yeah, what do you think if I add an e2e test as a follow-up chore? |
|
perfect 👍 |
Codecov Report
@@ Coverage Diff @@
## master #9419 +/- ##
=========================================
+ Coverage 64.8% 64.8% +<.01%
=========================================
Files 281 281
Lines 11998 12000 +2
Branches 2959 2960 +1
=========================================
+ Hits 7775 7777 +2
Misses 3591 3591
Partials 632 632
Continue to review full report at Codecov.
|
SimenB
reviewed
Jan 16, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found by @SimenB in a diff for
e2e/__tests__/__snapshots__/showConfig.test.ts.snapOuch, I assumed that all snapshot serializers support the
indentoption.But
jest-snapshot-serializer-rawdoes not, because it deals with strings.Because the snapshot is JSON serialization of an object, it can be dedented.
Therefore, the expected value has no indentation and the received value has default indentation. Only the opening and closing braces are in common.
As a future chore, add a minimal serializer to
test-utilswhich does not use the object-with-symbol-key-idiom, for tests that do not need to distinguish top-level strings from lower-level strings (for example, array items, object keys or values). That will support substring diffs for Jest test files that serialize only strings (like the example e2e test of CLI output).Test plan
Verified locally for the example of adding
"moduleWrapper": true,property:+ Received + 1- Snapshot - 122 + Received + 123+ Received + 1