Add timeout to prevent notifier from locking CPU on MacOS

[jackkinsella]

See discussion #8830

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[SimenB]

Please update the changelog as well 🙂

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

Maybe bump the dependency to the latest as well, while we're here? https://github.com/facebook/jest/blob/3ab2fc1b0ae3542bb8cdc927bf5459ba16a6420c/packages/jest-reporters/package.json#L25

[SimenB]

This is not an issue for the RN CLI, right? Since they don't use actions.

https://github.com/react-native-community/cli/blob/4d38c4cdb5a1e05c6670a046ef5a44afd655111a/packages/cli/package.json#L51
https://github.com/react-native-community/cli/blob/0d7f41d08373ec16c1e9e1d87040ec88a0200141/packages/cli/src/commands/server/messageSocket.js#L82-L88

[jackkinsella]

@SimenB It doesn't seem like it. You can verify blocking vs. non-blocking by saving and running the script below with node testWithAndWithoutActions.js with-actions (blocks) vs. node testWithAndWithoutActions.js (exits).

const process = require("process")
const notifier = require("node-notifier")

let args = {
  closeLabel: "Close",
  message: "⛔️ 1 of 9 tests failed",
  title: "12% Failed"
}

if (process.argv[2] === "with-actions") {
  console.log("Called with actions")
  args = Object.assign(args, { actions: ["Run again", "Exit tests"] })
} else {
  console.log("Called without actions")
}
notifier.notify(args, () => {})

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.