feat: add sync way of requiring and transpiling module #8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
approved these changes
Aug 11, 2019
There was a problem hiding this comment.
If it's passing, I say ship it - I'd also say be careful w/ this pattern, as it's very easy to cause problems w/ things like tooling (in particular b/c you've not got a discriminating parameter i.e usePromise: true).
I'll find out pretty quickly if it's going to cause trouble 馃槃
I'm a little surprised that compiles:
But it's pretty late for me, so I'm not going to question it.
jeysal
approved these changes
Aug 11, 2019
thymikee
approved these changes
Aug 14, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #8756 by adding an override that does not require you to handle a promise unless you pass your own function which returns a promise. This is needed for #8330.
I'm not sure I got the type info correct here, can somebody who actually knows TS tell me if this is correct? 馃槄 If it's hard with overrides, I'm happy to have another go with 2 different methods rather than
if (isPromise)./cc @M4rk9696 @G-Rath
Test plan
Still green CI
(purposefully no changelog entry as it's conceptually part of the unreleased #8756)