Simplify workaround that overrides Jest clone folder on Azure Pipelines #8413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8413 +/- ##
==========================================
+ Coverage 62.32% 62.34% +0.02%
==========================================
Files 266 266
Lines 10733 10734 +1
Branches 2615 2610 -5
==========================================
+ Hits 6689 6692 +3
+ Misses 3461 3460 -1
+ Partials 583 582 -1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This simplifies the Azure Pipelines-specific workaround that overrides the folder Jest gets cloned into during a CI build. See azure-pipelines-steps.yml (line 22).
Why this change? There is now a property on the "checkout" step that makes it easy to set the target directory of "git clone". This avoids the need for a separate step that copies the source to a different folder. This also simplifies the YAML.
Here's why this workaround was (and still is) necessary:
Test plan
Since this is an Azure Pipelines specific change, there is no impact to the functionality of Jest or existing tests. Just need to ensure the "Git checkout" step shows cloning into a "jest" folder and all tests pass correctly on Windows, Linux, and macOS.