Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar correction in Mock Function docs #8399

Merged
merged 1 commit into from May 3, 2019
Merged

Conversation

saylerb
Copy link
Contributor

@saylerb saylerb commented Apr 30, 2019

Simple grammar change in the Mock Function API documentation

Summary

Simple Grammar change, makes it read a little better.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #8399 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8399      +/-   ##
==========================================
+ Coverage   62.32%   62.34%   +0.01%     
==========================================
  Files         266      266              
  Lines       10733    10736       +3     
  Branches     2614     2610       -4     
==========================================
+ Hits         6689     6693       +4     
+ Misses       3461     3460       -1     
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-resolve/src/defaultResolver.ts 64.06% <0%> (-4.06%) ⬇️
packages/expect/src/print.ts 95.65% <0%> (-2.08%) ⬇️
packages/jest-config/src/index.ts 12.5% <0%> (+0.55%) ⬆️
packages/jest-snapshot/src/utils.ts 93.33% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b870306...469d438. Read the comment docs.

@jeysal
Copy link
Contributor

jeysal commented Apr 30, 2019

Thanks @saylerb!
Quick grep found a few more of these in JestObjectAPI.md files and a comment in jest-environment/src/index.ts, would you mind also fixing it there while we're at it? 😄

Simple grammar change to the description of `jest.restoreAllMocks()`
@saylerb
Copy link
Contributor Author

saylerb commented May 3, 2019

@jeysal Thanks for pointing that out! I found the other occurrences and made the changes, and squashed my commits into a single commit.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 27c4d9c into jestjs:master May 3, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants