Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Troubleshooting.md #6927

Merged
merged 2 commits into from Aug 31, 2018
Merged

Update Troubleshooting.md #6927

merged 2 commits into from Aug 31, 2018

Conversation

nickiaconis
Copy link
Contributor

@nickiaconis nickiaconis commented Aug 30, 2018

Summary

With the existing launch configuration, VS Code automatically appends --inspect-brk=<random_port> resulting in a command like node --inspect-brk ${workspaceRoot}/node_modules/.bin/jest --runInBand --inspect-brk=35370. This does not work because the debugger starts listening on port 9229, but Code attempts to attach to it on port 35370 (or whatever random port number it has selected).

Adding the port parameter prevents Code from automatically appending the --inspect-brk flag and instructs Code attach to the debugger on port 9229.

I don't think I'll need to update CHANGELOG.md for this, will I?

Test plan

This change does not include code per se, but I have run the launch configuration in my project and observed that it works properly.

With the existing launch configuration, VS Code automatically appends `--inspect-brk=<random_port>` resulting in a command like `node --inspect-brk ${workspaceRoot}/node_modules/.bin/jest --runInBand --inspect-brk=35370`. This does not work because the debugger is listening on port 9229, but Code is attempting to attach to it on port 35370.

Adding the port parameter prevents Code from automatically appending the `--inspect-brk` flag and instructs Code attach to the debugger on port 9229.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

I assume the same issue applies to Windows, but I am not in a position to test it.
@codecov-io
Copy link

Codecov Report

Merging #6927 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6927   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files         250      250           
  Lines       10379    10379           
  Branches        4        4           
=======================================
  Hits         6951     6951           
  Misses       3427     3427           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065a0b2...41a4dba. Read the comment docs.

@thymikee thymikee merged commit 24c173e into jestjs:master Aug 31, 2018
@thymikee
Copy link
Collaborator

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants