Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix broken link in Snapshot Testing docs #12254

Merged
merged 4 commits into from Feb 5, 2022

Conversation

robdy
Copy link
Contributor

@robdy robdy commented Jan 17, 2022

Summary

Motivation for that change is to make the hyperlink correct.

Test plan

I copied the link to my browser and ensured it's accessible.

@facebook-github-bot
Copy link
Contributor

Hi @robdy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@Biki-das Biki-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @robdy ,could you apply the changes to other versioned docs too as well as the doc folder

@robdy
Copy link
Contributor Author

robdy commented Jan 18, 2022

@Biki-das done

@Biki-das
Copy link
Contributor

@Biki-das done

@robdy thanks LGTM!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks!

@SimenB SimenB changed the title Fixes broken link in Snapshot Testing docs chore(docs): fix broken link in Snapshot Testing docs Feb 5, 2022
@SimenB SimenB merged commit 02506f8 into jestjs:main Feb 5, 2022
@robdy robdy deleted the patch-1 branch February 7, 2022 11:02
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants