Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require.resolve on default test sequencer and test environment #11482

Merged
merged 3 commits into from May 29, 2021
Merged

fix: require.resolve on default test sequencer and test environment #11482

merged 3 commits into from May 29, 2021

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented May 29, 2021

Summary

They are currently broken in yarn v2 pnp mode. See https://github.com/yarnpkg/berry/runs/2701218390
For example, I have to add @jest/test-sequencer and jest-environment-node as dependency to make the tests run in pnp mode. See SamChou19815/samlang#522

Test plan

Added test cases on test environment default resolution.

@codecov-commenter
Copy link

Codecov Report

Merging #11482 (03cb629) into master (50d590a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11482   +/-   ##
=======================================
  Coverage   68.94%   68.95%           
=======================================
  Files         312      312           
  Lines       16309    16310    +1     
  Branches     4721     4722    +1     
=======================================
+ Hits        11245    11246    +1     
  Misses       5036     5036           
  Partials       28       28           
Impacted Files Coverage Δ
packages/jest-config/src/normalize.ts 89.09% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d590a...03cb629. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants