Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pretty-print): add option printBasicPrototype #11441

Merged
merged 2 commits into from May 25, 2021
Merged

feat(pretty-print): add option printBasicPrototype #11441

merged 2 commits into from May 25, 2021

Conversation

remcohaszing
Copy link
Contributor

The new option printBasicPrototype determines whether or not the prototype should be printed for raw objects and arrays. By default this is true, which is backwards compatible.

Summary

I’m trying to create a snapshot matcher to test axios responses. In this case I’m interested pretty formatting JSON with custom matcher support, but I don’t want to print prototypes of raw objects or arrays, because I want to stay close to the original JSON data of the response.

Test plan

yarn jest

@facebook-github-bot
Copy link
Contributor

Hi @remcohaszing!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

The new option `printBasicPrototype` determines whether or not the prototype
should be printed for raw objects and arrays. By default this is `true`, which
is backwards compatible.
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

packages/pretty-format/src/index.ts Outdated Show resolved Hide resolved
@SimenB SimenB changed the title feat(pretty-print): add option printBasicPrototype feat(pretty-print): add option printBasicPrototype May 25, 2021
@SimenB SimenB merged commit b68d91b into jestjs:master May 25, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
@remcohaszing remcohaszing deleted the pretty-format-print-basic-prototype branch January 28, 2022 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants