Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run GC before collecting open handles #11278

Merged
merged 3 commits into from May 20, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 8, 2021

Summary

Fixes #11275. I've pushed 2 commits, one that I hoped would fix the issue, and then one that removes the warning.

The first commit worked (probably just because it waited a tick, nothing to do with GC), but it also made the test that asserts we warn about unclosed servers not detect anything.

Test plan

Test added

SimenB added a commit to Mr0grog/jest that referenced this pull request May 20, 2021
SimenB added a commit to Mr0grog/jest that referenced this pull request May 20, 2021
@SimenB SimenB merged commit 27bee72 into jestjs:master May 20, 2021
@SimenB SimenB deleted the open-handles-gc-run branch May 20, 2021 22:05
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node@15's crypto.randomFillSync() causing "RANDOMBYTESREQUEST potentially keeping Jest from exiting" errors
2 participants