feat: add support for dynamic imports in CJS

[SimenB]

Summary

Since we no longer use compileFunction, we can now implement this.

Test plan

Test added

[nicolo-ribaudo]

Should this work on Node.js 14.15.0 with Jest?

I have a CJS function like this one:

"use strict";

exports.default = import_;

function import_(filepath) {
  let res = import(filepath);
  throw new Error("Ok 2");
  return res;
}

When I call it with a valid filepath, Jest exits with a non-zero exit code without reporting any failure (I would expect it to throw "Ok 2").

I thus tried adding require("fs").writeFileSync("/tmp/linkModules-called", "ok"); as the first line of the linkModules function (which in this PR is directly used by importModuleDynamically) to check if it's called and it seems that it is never called 🤔

EDIT: It's a segmentation fault (core dumped), I'll try creating a smaller example and open a new issue.

[SimenB]

Should this work on Node.js 14.15.0 with Jest?

Definitely, as can be seen from the test here, this runs successfully on node@"^12.16.0 || >=13.7.0"

EDIT: It's a segmentation fault (core dumped), I'll try creating a smaller example and open a new issue.

That doesn't sound good 🙈 🙉 Ping me when/if you're able to put together a repository. If it's in Babel I'm happy to take a look at some branch

[pleunv]

Does this mean that babel-plugin-dynamic-import-node wouldn't be necessary anymore, or am I misunderstanding this PR?

[SimenB]

correct. If you use preset-env it will be disabled by default, but if you explicitly add it you can remove it

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.