New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): minor CSS improvements to logos #10410
Conversation
website/pages/en/index.js
Outdated
We have over 50 Sponsors who contribute $100 or more per | ||
month, and over 450 Backers who have contributed $2 or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this was the intention?
We have over 50 Sponsors who contribute $100 or more per | |
month, and over 450 Backers who have contributed $2 or | |
We have over {sponsorCount} Sponsors who contribute $100 or more per | |
month, and over {backerCount} Backers who have contributed $2 or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get this working when I tried, probably should drop those counts - will give it one more shot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this requires more discussion, this didn't seem fair to legit people who have donated on the premise that they would be recognized.
This comment has been minimized.
This comment has been minimized.
Update: Open Collective added a new Rejection feature and I've gone through and rejected over 70 backers that seem to be just using us for backlinks (e.g. casinos). I'll continue to monitor new donations as they come in, but I'd say the underlying issue here is solved. |
PR title has "minor CSS improvements to logos" - do we still want that or should this be closed? |
good point, I'll switch it to just the CSS |
SWitched |
@orta what about this? Does it reflect reality? |
Should we say something about rejection criteria? |
I don't really have a strong opinion on that |
@rickhanlonii thoughts? |
If we do say something it should just be that "We reserve the right to reject donations for any reason." |
We may want to call out "SEO" specifically in the note because I would guess that many donors don't know what nofollow means. What I added to the donation cards are:
I also filed opencollective/opencollective#3550 so we could put a not on the actual donation page before payment. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Switches the open collective info from showing logos to not, there's a trade-off here where we could have continued to make a more complex filter for what we show. But TBH, it's not really something we want to be actively keeping an eye on. So, rather than play whack-a-mole on the sponsors, this PR drops is completely.