Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): minor CSS improvements to logos #10410

Merged
merged 4 commits into from Oct 19, 2020
Merged

chore(website): minor CSS improvements to logos #10410

merged 4 commits into from Oct 19, 2020

Conversation

orta
Copy link
Member

@orta orta commented Aug 15, 2020

Summary

Screen Shot 2020-08-15 at 7 50 20 AM

Switches the open collective info from showing logos to not, there's a trade-off here where we could have continued to make a more complex filter for what we show. But TBH, it's not really something we want to be actively keeping an eye on. So, rather than play whack-a-mole on the sponsors, this PR drops is completely.

@orta
Copy link
Member Author

orta commented Aug 15, 2020

I also updated the about section:

Screen Shot 2020-08-15 at 7 56 06 AM

It used to warn folks they don't get SEO juice from OC sponsors, now it's more explicit.

Comment on lines 459 to 460
We have over 50 Sponsors who contribute $100 or more per
month, and over 450 Backers who have contributed $2 or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was the intention?

Suggested change
We have over 50 Sponsors who contribute $100 or more per
month, and over 450 Backers who have contributed $2 or
We have over {sponsorCount} Sponsors who contribute $100 or more per
month, and over {backerCount} Backers who have contributed $2 or

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get this working when I tried, probably should drop those counts - will give it one more shot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it doesn't handle interpolation, maybe I can wrap it into two

Screen Shot 2020-08-15 at 10 05 42 AM

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires more discussion, this didn't seem fair to legit people who have donated on the premise that they would be recognized.

@shaundouglas2014

This comment has been minimized.

@rickhanlonii
Copy link
Member

Update: Open Collective added a new Rejection feature and I've gone through and rejected over 70 backers that seem to be just using us for backlinks (e.g. casinos). I'll continue to monitor new donations as they come in, but I'd say the underlying issue here is solved.

@SimenB
Copy link
Member

SimenB commented Oct 2, 2020

PR title has "minor CSS improvements to logos" - do we still want that or should this be closed?

@orta
Copy link
Member Author

orta commented Oct 2, 2020

good point, I'll switch it to just the CSS

@orta
Copy link
Member Author

orta commented Oct 2, 2020

SWitched

@SimenB
Copy link
Member

SimenB commented Oct 2, 2020

I also updated the about section:

Screen Shot 2020-08-15 at 7 56 06 AM

It used to warn folks they don't get SEO juice from OC sponsors, now it's more explicit.

@orta what about this? Does it reflect reality?

@orta
Copy link
Member Author

orta commented Oct 2, 2020

@SimenB
Copy link
Member

SimenB commented Oct 2, 2020

Should we say something about rejection criteria?

@orta
Copy link
Member Author

orta commented Oct 3, 2020

I don't really have a strong opinion on that

@SimenB
Copy link
Member

SimenB commented Oct 12, 2020

@rickhanlonii thoughts?

@rickhanlonii
Copy link
Member

If we do say something it should just be that "We reserve the right to reject donations for any reason."

@rickhanlonii
Copy link
Member

We may want to call out "SEO" specifically in the note because I would guess that many donors don't know what nofollow means. What I added to the donation cards are:

Note: there are no SEO benefits to donating to the Jest collective.

I also filed opencollective/opencollective#3550 so we could put a not on the actual donation page before payment.

@SimenB SimenB changed the title Removes the sponsor logos and minor CSS improvements to logos chore(website): minor CSS improvements to logos Oct 19, 2020
@SimenB SimenB merged commit 8ea403d into master Oct 19, 2020
@SimenB SimenB deleted the de-logoify branch October 19, 2020 10:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants