Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExpectAPI.md #10141

Merged
merged 1 commit into from Jun 23, 2020
Merged

Update ExpectAPI.md #10141

merged 1 commit into from Jun 23, 2020

Conversation

dmarvasti
Copy link
Contributor

@dmarvasti dmarvasti commented Jun 8, 2020

(Typo) Removed word "to"

Summary

Identified a minor typo when reading documentation in context. Suggested change involves removing a single word ("to") from relevant documentation.

Test plan

(Typo) Removed word "to"
@facebook-github-bot
Copy link
Contributor

Hi @dmarvasti!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jeysal
Copy link
Contributor

jeysal commented Jun 8, 2020

Hi and thanks - can you also make this change in the old versions of the file within versioned_docs? This is so that your change will immediately appear on the latest version of the docs as well, not just in the next version until released :)

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit ee40194 into jestjs:master Jun 23, 2020
@SimenB
Copy link
Member

SimenB commented Jun 23, 2020

@dmarvasti a follow up that fixes the typo in the versioned docs as well would be greatly appreciated!

@dmarvasti
Copy link
Contributor Author

dmarvasti commented Jun 23, 2020 via email

sauravhiremath pushed a commit to MLH-Fellowship/jest that referenced this pull request Jul 20, 2020
(Typo) Removed word "to"
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants