Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should throw on for (async of []); #8651

Closed
fisker opened this issue Apr 29, 2021 · 0 comments
Closed

Should throw on for (async of []); #8651

fisker opened this issue Apr 29, 2021 · 0 comments
Labels
bug parsing

Comments

@fisker
Copy link

fisker commented Apr 29, 2021

Flow version: 0.149.0

Expected behavior

require('flow-parser').parse('for (async of []);')
{
  type: 'Program',
  loc: {
    source: null,
    start: { line: 1, column: 0 },
    end: { line: 1, column: 18 }
  },
  range: [ 0, 18 ],
 ...

Actual behavior

Should reject on parsing

  • Link to Try-Flow or Github repo:

https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoGBTALmAhgZwE8A7AYzAF4wBGVKOAJzAAoCTy4owBtAXQEoA3EA

Babel PR babel/babel#13208
Prettier issue prettier/prettier#10777
@mroch mroch added parsing and removed needs triage labels May 6, 2021
facebook-github-bot pushed a commit that referenced this issue Jan 4, 2023
@mroch @facebook-github-bot
[parser] error on for (async of [])
1d72c1c 
Summary: Fixes #8651

Reviewed By: SamChou19815

Differential Revision: D42187354

fbshipit-source-id: 042aa651ce1f05aaac35d83730f76b55556ee323
@fisker fisker mentioned this issue Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parsing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroch @fisker