Dynamic library for native dependency #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vthemelis
force-pushed
the
dynamic-library
branch
from
2a1aa74
to
f9c0ea2
Compare
This is needed to run the OCaml bit in bytecode. Signed-off-by: Vasilis Themelis <vdthemelis@gmail.com>
vthemelis
force-pushed
the
dynamic-library
branch
from
f9c0ea2
to
5ffdf42
Compare
|
@jasontatton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jasontatton, for some more context, this was needed to be able to run pyre in ocamldebug. I added some instruction on how to do that here: facebook/pyre-check#762 I have to say that the debugger doesn't work as well as you'd have hoped (ie it can just crash some times; probably because of the multi-processing) but I thought it was pretty valuable as it is. |
|
Thanks for raising this. I shall make a change which will have the same effect as this PR soon (so effectively merging it). I have to do it this way as our cargo.toml files are derived automatically based on some internal config which is not surfaced within this OSS repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
I'm not sure if this is correct for a multi-target CICD though.
At the moment it just looks into the Rust build output and copies the
.soor the.dylibfile depending on what is present.