Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translation): complete Japanese theme default translation #8075

Merged
merged 1 commit into from Sep 29, 2022

Conversation

pasora
Copy link
Contributor

@pasora pasora commented Sep 9, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I'd like to complete the Japanese default translations before proceeding to the Crowdin works.

Test Plan

Test links

Deploy preview: https://deploy-preview-8075--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @pasora!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Sep 9, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 05233d2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/631b488717a6e8000a5b1bfb
😎 Deploy Preview https://deploy-preview-8075--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 9, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 29, 2022
@slorber slorber changed the title refactor(theme-translation): Improve Japanese theme default translation fix(theme-translation): complete Japanese theme default translation Sep 29, 2022
@slorber
Copy link
Collaborator

slorber commented Sep 29, 2022

LGTM thanks 👍

@slorber slorber merged commit 883e468 into facebook:main Sep 29, 2022
@Josh-Cena Josh-Cena added pr: polish This PR adds a very minor behavior improvement that users will enjoy. and removed pr: bug fix This PR fixes a bug in a past release. labels Sep 29, 2022
@pasora pasora deleted the theme-default-translations-ja branch October 1, 2022 08:43
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Oct 7, 2022
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants