Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): preserve line breaks when copying code with showLineNumbers in Firefox #8068

Merged
merged 1 commit into from Sep 8, 2022

Conversation

acodecow
Copy link
Contributor

@acodecow acodecow commented Sep 8, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

bug still appears if showLineNumbers is true

Related issues/PRs

#5663 #5668

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 8, 2022
@netlify
Copy link

netlify bot commented Sep 8, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 41ac0f0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6319896fa5417f0008599965
😎 Deploy Preview https://deploy-preview-8068--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 85 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 72 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena changed the title Fix CodeBlock no line breaks copied in Firefox bug fix(theme): preserve line breaks when copying code with showLineNumbers in Firefox Sep 8, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Josh-Cena Josh-Cena merged commit 710c0c5 into facebook:main Sep 8, 2022
@acodecow acodecow deleted the patch-2 branch September 8, 2022 14:20
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 8, 2022
slorber pushed a commit that referenced this pull request Oct 28, 2022
…rs in Firefox (#8068)

Fix CodeBlock no line breaks copied in Firefox bug
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants