Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-blog): Fix blog feeds not generated #5835

Merged
merged 1 commit into from Nov 2, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 30, 2021

Motivation

Blog feeds are not generated anymore due to a typo in a recent refactor 馃槗

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

no :'( we should probably add some tests though

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 30, 2021
@slorber slorber requested a review from lex111 as a code owner October 30, 2021 10:05
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 30, 2021
@slorber slorber changed the title fix: Fix blog feeds not generated fix(content-blog): Fix blog feeds not generated Oct 30, 2021
@github-actions
Copy link

Size Change: 0 B

Total Size: 847 kB

鈩癸笍 View Unchanged
Filename Size
website/.docusaurus/globalData.json 38 kB
website/build/assets/css/styles.********.css 94 kB
website/build/assets/js/main.********.js 425 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB
website/build/blog/index.html 39 kB
website/build/docs/index.html 46.1 kB
website/build/docs/installation/index.html 53.6 kB
website/build/index.html 31.6 kB
website/build/tests/docs/index.html 27.3 kB
website/build/tests/docs/standalone/index.html 23.8 kB

compressed-size-action

@netlify
Copy link

netlify bot commented Oct 30, 2021

鉁旓笍 [V2]

馃敤 Explore the source changes: 68c4e07

馃攳 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617d18ffdc50bc000738e1e6

馃槑 Browse the preview: https://deploy-preview-5835--docusaurus-2.netlify.app

@github-actions
Copy link

鈿★笍 Lighthouse report for the changes in this PR:

Category Score
馃煝 Performance 98
馃煝 Accessibility 98
馃煝 Best practices 100
馃煝 SEO 100
馃煝 PWA 95

Lighthouse ran on https://deploy-preview-5835--docusaurus-2.netlify.app/

@lex111
Copy link
Contributor

lex111 commented Oct 31, 2021

we should probably add some tests though

Do you mean build simple site as Jest test? We had something like that in v1. https://github.com/facebook/docusaurus/blob/docusaurus-v1/packages/docusaurus-1.x/lib/__tests__/build-files.test.js

@lex111 lex111 merged commit c2009ab into main Nov 2, 2021
@lex111 lex111 deleted the slorber/fix-blog-feeds-not-generated branch November 2, 2021 16:28
@slorber
Copy link
Collaborator Author

slorber commented Nov 3, 2021

Do you mean build simple site as Jest test? We had something like that in v1. docusaurus-v1/packages/docusaurus-1.x/lib/tests/build-files.test.js

Yes, this kind of test can probably be done after the end of the e2e workflow, not sure where to put the files though because it shouldn't execute by default when running yarn test

@Josh-Cena
Copy link
Collaborator

Prettier has a separate repo with fixtures for testing new releases. Maybe we can make a mock site repo as well馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants