fix: baseUrl passed to sortConfig #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5824--docusaurus-2.netlify.app/ |
|
LGTM thanks 👍 Can you also add a test covering this fixed edge case? |
|
✔️ [V2] 🔨 Explore the source changes: 19d3677 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617bfc359593f10007386b4f 😎 Browse the preview: https://deploy-preview-5824--docusaurus-2.netlify.app |
semoal
force-pushed
the
semoal/fix-baseUrl-sort-config
branch
from
e0db05a
to
19d3677
Compare
|
Thanks 👍 (the lint issue is not your PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To close #5799
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)